Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11341 )
Change subject: IMPALA-7424: Reduce in-memory footprint of incremental stats ...................................................................... Patch Set 7: (5 comments) couple of small comments/questions around edge-cases. otherwise, lgtm. http://gerrit.cloudera.org:8080/#/c/11341/7/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/11341/7/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@530 PS7, Line 530: private boolean hasIncrementalStats_; start this off at false. I could not easily see when its set (I see from thrift, but from the constructor, its less clear since the setter is in a try block, L667). http://gerrit.cloudera.org:8080/#/c/11341/7/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@690 PS7, Line 690: Preconditions.checkState( what happens if the hms param was corrupted so the extraction on L665 threw an exception? that's not under our control. http://gerrit.cloudera.org:8080/#/c/11341/7/fe/src/main/java/org/apache/impala/catalog/PartitionStatsUtil.java File fe/src/main/java/org/apache/impala/catalog/PartitionStatsUtil.java: http://gerrit.cloudera.org:8080/#/c/11341/7/fe/src/main/java/org/apache/impala/catalog/PartitionStatsUtil.java@65 PS7, Line 65: decompressed null on an internal exception in deflateDecompress http://gerrit.cloudera.org:8080/#/c/11341/7/fe/src/main/java/org/apache/impala/catalog/PartitionStatsUtil.java@149 PS7, Line 149: decompressed can be null if there's an exception in deflateDecompress. http://gerrit.cloudera.org:8080/#/c/11341/7/fe/src/main/java/org/apache/impala/util/CompressionUtil.java File fe/src/main/java/org/apache/impala/util/CompressionUtil.java: http://gerrit.cloudera.org:8080/#/c/11341/7/fe/src/main/java/org/apache/impala/util/CompressionUtil.java@64 PS7, Line 64: return null why is this null in this case, but empty in the compress case (L49)? caller would be simplified to remove this. -- To view, visit http://gerrit.cloudera.org:8080/11341 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39f02ebfa0c6e9b0baedd0d76058a1b34efb5a02 Gerrit-Change-Number: 11341 Gerrit-PatchSet: 7 Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 31 Aug 2018 16:18:39 +0000 Gerrit-HasComments: Yes
