Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11369 )
Change subject: IMPALA-7517. Fix hang in scanner threads when soft limit is exceeded ...................................................................... IMPALA-7517. Fix hang in scanner threads when soft limit is exceeded As described in the JIRA, when scanner threads see that the soft limit has been exceeded, they try to shut down. In some particular interleavings, this would cause all of the scanner threads to exit without any of them marking the scan as completed. This patch adds a new fault point to inject fake soft limit errors, and adds this fault point to the scanner test. With the previous placement of the soft limit check, this caused query hangs pretty reliably. With the new placement of the memory limit check, it now passes. Change-Id: I3dc1a2ec79c823575d7d40e7b52216dea5b0ddde Reviewed-on: http://gerrit.cloudera.org:8080/11369 Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Reviewed-by: Todd Lipcon <t...@apache.org> --- M be/src/exec/hdfs-scan-node.cc M tests/query_test/test_scanners.py 2 files changed, 12 insertions(+), 5 deletions(-) Approvals: Impala Public Jenkins: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11369 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3dc1a2ec79c823575d7d40e7b52216dea5b0ddde Gerrit-Change-Number: 11369 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
