Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11376 )
Change subject: IMPALA-7519: Support elliptic curve ssl ciphers ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11376/1/be/src/rpc/thrift-server.cc File be/src/rpc/thrift-server.cc: http://gerrit.cloudera.org:8080/#/c/11376/1/be/src/rpc/thrift-server.cc@372 PS1, Line 372: c_unique_ptr<EC_KEY> ecdh { EC_KEY_new_by_curve_name(NID_X9_62_prime256v1), &EC_KEY_free }; line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/11376/1/tests/custom_cluster/test_client_ssl.py File tests/custom_cluster/test_client_ssl.py: http://gerrit.cloudera.org:8080/#/c/11376/1/tests/custom_cluster/test_client_ssl.py@114 PS1, Line 114: flake8: E261 at least two spaces before inline comment -- To view, visit http://gerrit.cloudera.org:8080/11376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1666ceabec51b425e8a82be1cf519e2ac35fa5a6 Gerrit-Change-Number: 11376 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 31 Aug 2018 23:44:04 +0000 Gerrit-HasComments: Yes