Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11388 )
Change subject: WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11388/1/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/11388/1/be/src/service/client-request-state.cc@78 PS1, Line 78: frontend_profile_(RuntimeProfile::Create(&profile_pool_, "Frontend")), perhaps I can leave this out entirely and only instantiate it (and add as a child) in SetFrontendProfile? http://gerrit.cloudera.org:8080/#/c/11388/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/11388/1/be/src/service/impala-server.cc@954 PS1, Line 954: (*request_state)->SetFrontendProfile(result.profile); does anyone understand the threading model of the runtime profile stuff? could I do this inline as part of 'Exec' below instead or is this lock necessary? -- To view, visit http://gerrit.cloudera.org:8080/11388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I808d55a225338912ebaebd0cf71c36db944b7276 Gerrit-Change-Number: 11388 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Wed, 05 Sep 2018 02:18:52 +0000 Gerrit-HasComments: Yes
