Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11359 )
Change subject: IMPALA-7203. Support UDFs in CatalogdMetaProvider ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/11359/6/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/11359/6/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@761 PS6, Line 761: req, "missing expected function"); > nit: single line Done http://gerrit.cloudera.org:8080/#/c/11359/6/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1154 PS6, Line 1154: an > nit: a Done http://gerrit.cloudera.org:8080/#/c/11359/6/fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java File fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java: http://gerrit.cloudera.org:8080/#/c/11359/6/fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java@191 PS6, Line 191: functions > nit: function names? Done http://gerrit.cloudera.org:8080/#/c/11359/6/fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java@219 PS6, Line 219: from HMS > omit... could this change from getting these functions from catalogd or dir Done -- To view, visit http://gerrit.cloudera.org:8080/11359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifef8ece9f214dca9441833b00f65c7c152d0ab53 Gerrit-Change-Number: 11359 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Wed, 05 Sep 2018 23:25:07 +0000 Gerrit-HasComments: Yes
