Anonymous Coward #431 has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 )
Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/10855/12/common/protobuf/CMakeLists.txt File common/protobuf/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/10855/12/common/protobuf/CMakeLists.txt@47 PS12, Line 47: KRPC_GENERATE(CONTROL_SVC_PROTO_SRCS CONTROL_SVC_PROTO_HDRS You could factor out the replication of the protobuf generation by putting in a loop: cmake_minimum_required(VERSION 2.6) set(PROTOBUF_OUTPUT_DIR ${CMAKE_SOURCE_DIR}/be/generated-sources/gen-cpp/) add_custom_target(proto-deps DEPENDS token_proto rpc_header_proto data_stream_svc_proto) foreach(pb_src COMMON ROW_BATCH CONTROL_SERVICE_PROTO) string(TOLOWER "${pb_src}_proto" "${pb_src}_PROTO_TGT") string(TOLOWER "${pb_src}.proto" "${pb_src}_PROTO_SRC") PROTOBUF_GENERATE_CPP("${pb_src}_PROTO_SRCS" "${pb_src}_PROTO_HDRS" "${pb_src}_PROTO_TGTS" SOURCE_ROOT ${CMAKE_CURRENT_SOURCE_DIR} BINARY_ROOT ${PROTOBUF_OUTPUT_DIR} PROTO_FILES "${${pb_src}_PROTO_SRC}") add_custom_target("${${pb_src}_PROTO_TGT}" DEPENDS "${${pb_src}_PROTO_TGTS}") set("${pb_src}_PROTO_SRCS}" "${${pb_src}_PROTO_SRCS}" PARENT_SCOPE) add_dependencies(proto-deps "${${pb_src}_PROTO_TGT}") endforeach(pb_src) KRPC_GENERATE(DATA_STREAM_SVC_PROTO_SRCS DATA_STREAM_SVC_PROTO_HDRS DATA_STREAM_SVC_PROTO_TGTS SOURCE_ROOT ${CMAKE_CURRENT_SOURCE_DIR} BINARY_ROOT ${PROTOBUF_OUTPUT_DIR} PROTO_FILES data_stream_service.proto) add_custom_target(data_stream_svc_proto DEPENDS ${DATA_STREAM_SVC_PROTO_TGTS}) set(DATA_STREAM_SVC_PROTO_SRCS ${DATA_STREAM_SVC_PROTO_SRCS} PARENT_SCOPE) KRPC_GENERATE(RPC_TEST_PROTO_SRCS RPC_TEST_PROTO_HDRS RPC_TEST_PROTO_TGTS SOURCE_ROOT ${CMAKE_CURRENT_SOURCE_DIR} BINARY_ROOT ${PROTOBUF_OUTPUT_DIR} PROTO_FILES rpc_test.proto) add_custom_target(rpc_test_proto_tgt DEPENDS ${RPC_TEST_PROTO_TGTS}) set(RPC_TEST_PROTO_SRCS ${RPC_TEST_PROTO_SRCS} PARENT_SCOPE) -- To view, visit http://gerrit.cloudera.org:8080/10855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7638583b433dcac066b87198e448743d90415ebe Gerrit-Change-Number: 10855 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Anonymous Coward #431 Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 07 Sep 2018 22:14:32 +0000 Gerrit-HasComments: Yes
