Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11433 )
Change subject: IMPALA-3819: Clarify stale block metadata warning message ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11433/1/be/src/exec/hdfs-scan-node-base.cc File be/src/exec/hdfs-scan-node-base.cc: http://gerrit.cloudera.org:8080/#/c/11433/1/be/src/exec/hdfs-scan-node-base.cc@913 PS1, Line 913: runtime_state_->LogError(ErrorMsg(TErrorCode::GENERAL, Substitute( If this does not result in incorrect query results, I wonder if logging it as an error is appropriate. IMO this is probably a WARN or INFO message. http://gerrit.cloudera.org:8080/#/c/11433/1/be/src/exec/hdfs-scan-node-base.cc@914 PS1, Line 914: "Read $0 of data across network that was expected to be local. Block locality " Worth prefixing the message with the query/Finst Id? -- To view, visit http://gerrit.cloudera.org:8080/11433 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9eb2672393c5ff4e0670d247d684278283012a3 Gerrit-Change-Number: 11433 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Wed, 12 Sep 2018 20:17:34 +0000 Gerrit-HasComments: Yes
