Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/11431 )
Change subject: IMPALA-7559: Disable stat filtering for UTC-normalized timestamp columns ...................................................................... Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/11431/3/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/11431/3/be/src/exec/hdfs-parquet-scanner.cc@517 PS3, Line 517: IsTimezoneConversionNeededForTimestamps() nit: this call could be moved out of the loop, before L465 http://gerrit.cloudera.org:8080/#/c/11431/3/testdata/data/README File testdata/data/README: http://gerrit.cloudera.org:8080/#/c/11431/3/testdata/data/README@222 PS3, Line 222: Contains a single row. It is used to test IMPALA-7559 which only occurs when all : values in a column chunk are the same timestamp and the file is written with : parquet-mr (which is used by Hive). Thanks for adding the description! nit: apply the 90-char line policy. -- To view, visit http://gerrit.cloudera.org:8080/11431 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4c02230993f2390c03d513f08bae2e9d3d538fa Gerrit-Change-Number: 11431 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 13 Sep 2018 15:37:05 +0000 Gerrit-HasComments: Yes
