Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11425 )
Change subject: IMPALA-2063 Remove newline characters in query status. ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11425/3/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/11425/3/be/src/util/runtime-profile.cc@547 PS3, Line 547: size_t size = value.size(); : if (size > 0 && value.at(size - 1) == '\n') { : value.resize(size - 1); : } It seems more robust to strip any trailing whitespace by using find_last_not_of(" \t\f\v\n\r") to find the last non-whitespace char and use substr() to extract the part which is valid. Just a suggestion, not dictating the implementation. -- To view, visit http://gerrit.cloudera.org:8080/11425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2bbd7d7fe2c6d0f3799d0e6b336710bccfef0ab1 Gerrit-Change-Number: 11425 Gerrit-PatchSet: 3 Gerrit-Owner: Michal Ostrowski <mostr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Thu, 13 Sep 2018 20:47:01 +0000 Gerrit-HasComments: Yes
