Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11444 )
Change subject: IMPALA-7556: part 1: handle different file systems via polymorphism ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/11444/2/be/src/runtime/io/hdfs-file-reader.cc File be/src/runtime/io/hdfs-file-reader.cc: http://gerrit.cloudera.org:8080/#/c/11444/2/be/src/runtime/io/hdfs-file-reader.cc@132 PS2, Line 132: GetHdfsErrorMsg("Error reading from HDFS file: ", *scan_range_->file_string())); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/11444/2/be/src/runtime/io/hdfs-file-reader.cc@142 PS2, Line 142: position_in_file, *scan_range_->file_string(), GetHdfsErrorMsg(""))); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/11444/2/be/src/runtime/io/hdfs-file-reader.cc@207 PS2, Line 207: if (scan_range_->external_buffer_tag_ == ScanRange::ExternalBufferTag::CACHED_BUFFER) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/11444/2/be/src/runtime/io/hdfs-file-reader.cc@265 PS2, Line 265: hadoopReadZero(exclusive_hdfs_fh_->file(), io_mgr_->cached_read_options(), scan_range_->len()); line too long (101 > 90) -- To view, visit http://gerrit.cloudera.org:8080/11444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d3d2d774075008285230606b992603d5be1a82 Gerrit-Change-Number: 11444 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 14 Sep 2018 18:00:08 +0000 Gerrit-HasComments: Yes
