Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11443 )
Change subject: IMPALA-6202. mod and % are not equivalent. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11443/1/fe/src/main/java/org/apache/impala/analysis/Expr.java File fe/src/main/java/org/apache/impala/analysis/Expr.java: http://gerrit.cloudera.org:8080/#/c/11443/1/fe/src/main/java/org/apache/impala/analysis/Expr.java@448 PS1, Line 448: equals("mod") this seems fairly special cased. I'm wondering if the functionCall expr is the place to do this... it seems to have special cases there for v2 type handling. http://gerrit.cloudera.org:8080/#/c/11443/1/testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test File testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test: http://gerrit.cloudera.org:8080/#/c/11443/1/testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test@515 PS1, Line 515: ---- QUERY pls add unit tests as well to AnalyzeExprsTest.java. if '%' and 'mod' are equiv, then it should not be hard to extend all tests against the '%' arithmetic expr to also confirm the same behavior with 'mod'. -- To view, visit http://gerrit.cloudera.org:8080/11443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0067da04083859ffbf662a29007154461bea2ba Gerrit-Change-Number: 11443 Gerrit-PatchSet: 1 Gerrit-Owner: Yongjun Zhang <yjzhan...@apache.org> Gerrit-Reviewer: Dan Hecht <dhecht.apa...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 14 Sep 2018 18:08:16 +0000 Gerrit-HasComments: Yes
