Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11406 )
Change subject: IMPALA-5031: undefined behavior: codegen signed overflow ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11406/1/be/src/exprs/operators-ir.cc File be/src/exprs/operators-ir.cc: http://gerrit.cloudera.org:8080/#/c/11406/1/be/src/exprs/operators-ir.cc@65 PS1, Line 65: retur > I'm pretty sure all real implementations put the standard libc functions in removed http://gerrit.cloudera.org:8080/#/c/11406/2/be/src/exprs/operators-ir.cc File be/src/exprs/operators-ir.cc: http://gerrit.cloudera.org:8080/#/c/11406/2/be/src/exprs/operators-ir.cc@68 PS2, Line 68: #define BITNOT_FN(TYPE)\ > I'm ok with relying on clang's undocumented behaviour so long as we have a Added tests that work at compile time. -- To view, visit http://gerrit.cloudera.org:8080/11406 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79ec3a5ed974709e5e47be6b074d39ee89461f7f Gerrit-Change-Number: 11406 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Dan Hecht <dhecht.apa...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 20 Sep 2018 04:54:40 +0000 Gerrit-HasComments: Yes
