Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11483 )
Change subject: IMPALA-7537: REVOKE GRANT OPTION regression ...................................................................... Patch Set 9: Code-Review+1 (2 comments) carry +1 http://gerrit.cloudera.org:8080/#/c/11483/7/fe/src/main/java/org/apache/impala/util/SentryProxy.java File fe/src/main/java/org/apache/impala/util/SentryProxy.java: http://gerrit.cloudera.org:8080/#/c/11483/7/fe/src/main/java/org/apache/impala/util/SentryProxy.java@476 PS7, Line 476: > I am still not 100% ok with the naming - privWithGrant has the negated vers Done http://gerrit.cloudera.org:8080/#/c/11483/8/fe/src/main/java/org/apache/impala/util/SentryProxy.java File fe/src/main/java/org/apache/impala/util/SentryProxy.java: http://gerrit.cloudera.org:8080/#/c/11483/8/fe/src/main/java/org/apache/impala/util/SentryProxy.java@482 PS8, Line 482: if (rolePriv != null) { : rolePrivileges.add(rolePriv); : } > I have noticed that in CatalogOpEcexutor the last element's version is used Done -- To view, visit http://gerrit.cloudera.org:8080/11483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3be5c8f15e9bc53e9661347578832bf446abaedc Gerrit-Change-Number: 11483 Gerrit-PatchSet: 9 Gerrit-Owner: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 25 Sep 2018 17:58:38 +0000 Gerrit-HasComments: Yes
