Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11468 )
Change subject: IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics. ...................................................................... Patch Set 5: (4 comments) I think I fixed the line-length and whitespace issues. Tim--care to take another look? Thanks! http://gerrit.cloudera.org:8080/#/c/11468/4/be/src/util/memory-metrics.h File be/src/util/memory-metrics.h: http://gerrit.cloudera.org:8080/#/c/11468/4/be/src/util/memory-metrics.h@223 PS4, Line 223: const string& key, > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/11468/2/be/src/util/memory-metrics.cc File be/src/util/memory-metrics.cc: http://gerrit.cloudera.org:8080/#/c/11468/2/be/src/util/memory-metrics.cc@257 PS2, Line 257: int64_t JvmMetricCache::GetPoolMetric(const std::string& mempool_name, > line too long (98 > 90) Done http://gerrit.cloudera.org:8080/#/c/11468/4/be/src/util/memory-metrics.cc File be/src/util/memory-metrics.cc: http://gerrit.cloudera.org:8080/#/c/11468/4/be/src/util/memory-metrics.cc@257 PS4, Line 257: int64_t JvmMetricCache::GetPoolMetric(const std::string& mempool_name, > line too long (98 > 90) Done http://gerrit.cloudera.org:8080/#/c/11468/4/tests/infra/test_jvm_metrics.py File tests/infra/test_jvm_metrics.py: http://gerrit.cloudera.org:8080/#/c/11468/4/tests/infra/test_jvm_metrics.py@20 PS4, Line 20: > flake8: E302 expected 2 blank lines, found 1 Done -- To view, visit http://gerrit.cloudera.org:8080/11468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia707393962ad94ef715ec015b3fe3bb1769104a2 Gerrit-Change-Number: 11468 Gerrit-PatchSet: 5 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 25 Sep 2018 22:35:38 +0000 Gerrit-HasComments: Yes
