Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 )
Change subject: IMPALA-376: add built-in functions for parsing JSON ...................................................................... Patch Set 15: Code-Review+1 (4 comments) Thanks for your patience and addressing the comments. LGTM once a few small things are fix. I'll give Zoltan a chance to take another look since he's in a different time zone (CET). http://gerrit.cloudera.org:8080/#/c/10950/15/be/src/exprs/string-functions.cc File be/src/exprs/string-functions.cc: http://gerrit.cloudera.org:8080/#/c/10950/15/be/src/exprs/string-functions.cc@72 PS15, Line 72: if (originalSize >= newSize) Put conditional on a single line. http://gerrit.cloudera.org:8080/#/c/10950/15/be/src/exprs/string-functions.cc@143 PS15, Line 143: RETURN_IF_OOM(v.Accept(writer), StringVal::null()) Can't we use RETURN_NULL_IF_OOM in some of these places? http://gerrit.cloudera.org:8080/#/c/10950/15/be/src/exprs/string-functions.cc@267 PS15, Line 267: Expect Nit: "Expected" http://gerrit.cloudera.org:8080/#/c/10950/15/be/src/exprs/string-functions.cc@389 PS15, Line 389: case ' ': ++i; Maybe put ++i on the next line? formatting looks weird. -- To view, visit http://gerrit.cloudera.org:8080/10950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9d3598cb3beca0865a7edb094f3a5b602dbd2f Gerrit-Change-Number: 10950 Gerrit-PatchSet: 15 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 26 Sep 2018 20:23:44 +0000 Gerrit-HasComments: Yes
