Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11468 )
Change subject: IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics. ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/11468/8/be/src/util/memory-metrics.cc File be/src/util/memory-metrics.cc: http://gerrit.cloudera.org:8080/#/c/11468/8/be/src/util/memory-metrics.cc@246 PS8, Line 246: ok() > Looks serious enough to log rather than silently returning. Done http://gerrit.cloudera.org:8080/#/c/11468/8/be/src/util/memory-metrics.cc@295 PS8, Line 295: for (const TJvmMemoryPool& usage: last_response_.memory_pools) { > Can we DCHECK that last_response_ is not nullptr? Could happen if GrabMetri last_response_ isn't a pointer. Thrift seems to use std::vector internally (see be/generated-sources/gen-cpp/Frontend_types.h) so I think it's always initialized. That said, this pointed out that I hadn't initialized last_fetch_, which I now have. -- To view, visit http://gerrit.cloudera.org:8080/11468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia707393962ad94ef715ec015b3fe3bb1769104a2 Gerrit-Change-Number: 11468 Gerrit-PatchSet: 8 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 26 Sep 2018 22:06:41 +0000 Gerrit-HasComments: Yes
