Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11528 )
Change subject: IMPALA-3710: All-null columns give wrong estimates in planner Modified the planner to handle low-value NDVs by adjusting them upward by one to account for null values. Thus, even an all-null column, which has an NDV of 0 in stats, will have an NDV of 1 in ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11528/3/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/11528/3/fe/src/main/java/org/apache/impala/service/Frontend.java@1142 PS3, Line 1142: private TExecRequest doCreateExecRequest(PlanCtx planCtx, EventSequence timeline) throws ImpalaException { line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/11528/3/fe/src/test/java/org/apache/impala/planner/CardinalityTest.java File fe/src/test/java/org/apache/impala/planner/CardinalityTest.java: http://gerrit.cloudera.org:8080/#/c/11528/3/fe/src/test/java/org/apache/impala/planner/CardinalityTest.java@180 PS3, Line 180: System.out.println(plan.get(0).getExplainString(queryOptions, TExplainLevel.EXTENDED)); line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/11528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife657a43c9cafc451bd12ddf857dcb7169e97459 Gerrit-Change-Number: 11528 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 27 Sep 2018 18:17:18 +0000 Gerrit-HasComments: Yes