Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11534 )
Change subject: IMPALA-7622: adds profile metrics when fetching incremental stats ...................................................................... Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/11534/1/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/11534/1/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@683 PS1, Line 683: tats = > clarified to compressedByteSize. agreed. http://gerrit.cloudera.org:8080/#/c/11534/2/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/11534/2/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@122 PS2, Line 122: private static final String STATS_FETCH_TIME = STATS_FETCH_PREFIX + ".Time"; : private static final String STATS_FETCH_COMPRESSED_BYTES = : STATS_FETCH_PREFIX + ".CompressedBytes"; : private static final String STATS_FETCH_TOTAL_PARTITIONS = : STATS_FETCH_PREFIX + ".TotalPartitions"; : private static final String STATS_FETCH_NUM_PARTITIONS_WITH_STATS = : STATS_FETCH_PREFIX + ".NumPartitionsWithStats"; Sorry missed this in the first round. Would be nice to add one-liners that document what each of these metrics intends to collect. -- To view, visit http://gerrit.cloudera.org:8080/11534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9b268548c7a98c751eb99855ee08313d1d5a903 Gerrit-Change-Number: 11534 Gerrit-PatchSet: 2 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 28 Sep 2018 04:45:30 +0000 Gerrit-HasComments: Yes
