Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11521 )
Change subject: IMPALA-7595: Check the validity of the time part of Parquet timestamps ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/11521/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11521/3//COMMIT_MSG@30 PS3, Line 30: > Yeah, but the current error message is a bit misleading IMO, since currentl I have thought a bit about this and added a new error code. The rationale is that if someone will work on the encoder, then the distinct error codes can help in identifying bugs. http://gerrit.cloudera.org:8080/#/c/11521/3/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/11521/3/be/src/exec/parquet-column-readers.cc@697 PS3, Line 697: !TimestampValue::IsValidDate(val->date()) : || !TimestampValue::IsValidTime(val->time()) > Would it make sense to merge these two functions and have a single Timestam I have kept them as separate functions to be able to distinguish between the two kind of errors. Another reason is that https://gerrit.cloudera.org/#/c/11183/ handles the two errors differently - out of range dates are replaced with not_a_date, while invalid times lead to DCHECK. It is done this way to avoid the performance impact of checking times by relying on callers giving correct values. I plan to check dates with DCHECK too, but that will need some additional changes. http://gerrit.cloudera.org:8080/#/c/11521/3/be/src/runtime/timestamp-value.h File be/src/runtime/timestamp-value.h: http://gerrit.cloudera.org:8080/#/c/11521/3/be/src/runtime/timestamp-value.h@195 PS3, Line 195: than > nit: than Done -- To view, visit http://gerrit.cloudera.org:8080/11521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc0ae651b6a0a028c61a15fd069ef9e904231058 Gerrit-Change-Number: 11521 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 28 Sep 2018 13:20:50 +0000 Gerrit-HasComments: Yes
