Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11539 )
Change subject: IMPALA-7599: make the number of local cache retries configurable ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/11539/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11539/1//COMMIT_MSG@15 PS1, Line 15: Made several fixes to exception messages. whats this? http://gerrit.cloudera.org:8080/#/c/11539/1/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/11539/1/be/src/runtime/exec-env.cc@97 PS1, Line 97: local_catalog_max_retries Make it more clear, --local_catalog_max_metadata_fetch_retries / --local_catalog_max_plan_retries or something like that? Doesn't tell what is being retried. http://gerrit.cloudera.org:8080/#/c/11539/1/be/src/runtime/exec-env.cc@99 PS1, Line 99: frontend Just to be sure, do we plan to skip these retries for non-fe paths? Like directly accessing the Catalog http://gerrit.cloudera.org:8080/#/c/11539/1/tests/custom_cluster/test_local_catalog.py File tests/custom_cluster/test_local_catalog.py: http://gerrit.cloudera.org:8080/#/c/11539/1/tests/custom_cluster/test_local_catalog.py@220 PS1, Line 220: Tests that the flag to limit the number of retries works Maybe I'm missing something but we don't seem to be doing this? We set max_retries=0 and asserting total_ex_throws > 0. http://gerrit.cloudera.org:8080/#/c/11539/1/tests/custom_cluster/test_local_catalog.py@251 PS1, Line 251: else, do we need to re-throw and fail? -- To view, visit http://gerrit.cloudera.org:8080/11539 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f14d5a8728f3cb07c7710589c44c2cd52478ba8 Gerrit-Change-Number: 11539 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 28 Sep 2018 15:28:05 +0000 Gerrit-HasComments: Yes
