Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 )
Change subject: IMPALA-6323 Allow constant expressions in "partition by". ...................................................................... Patch Set 1: I think this also needs an end-to-end test to make sure that this gets handled correctly in the planner and query execution (there's no specific reason to expect that it doesn't work, but the test coverage seems useful). -- To view, visit http://gerrit.cloudera.org:8080/11556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf129026c45120e9470df601268863634037908c Gerrit-Change-Number: 11556 Gerrit-PatchSet: 1 Gerrit-Owner: Michal Ostrowski <mostr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 01 Oct 2018 20:40:10 +0000 Gerrit-HasComments: No
