Anuj Phadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11540 )
Change subject: [WIP] IMPALA-7555: Set socket timeout in impala-shell ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/11540/3/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/11540/3/shell/impala_client.py@81 PS3, Line 81: int(client_connect_timeout_ms) > Any idea what happens if the user passes a negative value ? Also, it seems Nope it does not work. ./bin/impala-shell.sh -i localhost:1234 -t -1 -q "show tables" Starting Impala Shell without Kerberos authentication Error connecting: ValueError, Timeout value out of range Not connected to Impala, could not execute queries. anuj@anuj-OptiPlex-9020:~/Impala$ setTimeout converts it to float by dividing the ms by 1000.0 I am ok with converting it to int here and it getting implicitly typecasted to a float http://gerrit.cloudera.org:8080/#/c/11540/3/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/11540/3/shell/impala_shell.py@a864 PS3, Line 864: > Why was this removed ? Moved it back. http://gerrit.cloudera.org:8080/#/c/11540/3/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/11540/3/shell/option_parser.py@225 PS3, Line 225: "-t", "--client_connect_timeout_ms" > Do you think it makes sense to have a value (e.g. 0) which allows user to d I tried setting it here 1. anuj@anuj-OptiPlex-9020:~/Impala$ time ./bin/impala-shell.sh -i localhost:1234 -t 0 -q "show tables" Starting Impala Shell without Kerberos authentication Error connecting: TTransportException, Could not connect to localhost:1234 Not connected to Impala, could not execute queries. real 0m0.121s user 0m0.084s sys 0m0.028s anuj@anuj-OptiPlex-9020:~/Impala$ 2. I tried reverting it back to 0 (in connect()) and that resulted in some of the tests failing. http://gerrit.cloudera.org:8080/#/c/11540/3/shell/option_parser.py@227 PS3, Line 227: i > nit: missing space before "if" Done http://gerrit.cloudera.org:8080/#/c/11540/3/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/11540/3/tests/shell/test_shell_commandline.py@740 PS3, Line 740: > nit: extra whitespace Done http://gerrit.cloudera.org:8080/#/c/11540/3/tests/shell/test_shell_commandline.py@742 PS3, Line 742: indefinitely > indefinitely ? Done -- To view, visit http://gerrit.cloudera.org:8080/11540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I130fc47f7a83f591918d6842634b4e5787d00813 Gerrit-Change-Number: 11540 Gerrit-PatchSet: 4 Gerrit-Owner: Anuj Phadke <apha...@cloudera.com> Gerrit-Reviewer: Anuj Phadke <apha...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Comment-Date: Tue, 02 Oct 2018 20:50:40 +0000 Gerrit-HasComments: Yes
