Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 )
Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC ...................................................................... Patch Set 14: Code-Review+1 (6 comments) I wasn't able to do a particularly deep review but I don't think that should hold things up. Looks great at a high level and I'm excited to get it in. Had a few minor suggestions but nothing critical. http://gerrit.cloudera.org:8080/#/c/10855/14/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/10855/14/be/src/runtime/coordinator-backend-state.cc@275 PS14, Line 275: unique_lock<mutex> lock(lock_); Can we document the lock order in coordinator.h (which already references ExecSummary::lock) http://gerrit.cloudera.org:8080/#/c/10855/14/be/src/runtime/fragment-instance-state.h File be/src/runtime/fragment-instance-state.h: http://gerrit.cloudera.org:8080/#/c/10855/14/be/src/runtime/fragment-instance-state.h@177 PS14, Line 177: Monontonically Typo: Monotonically http://gerrit.cloudera.org:8080/#/c/10855/14/be/src/runtime/fragment-instance-state.h@179 PS14, Line 179: int32_t report_seq_no_ = 0; I imagine you already thought about this and concluded that overflows were not possible, but I'm wondering why not just make it an int64_t anyway so that it's super-obvious that it's not possible. http://gerrit.cloudera.org:8080/#/c/10855/14/be/src/runtime/fragment-instance-state.cc File be/src/runtime/fragment-instance-state.cc: http://gerrit.cloudera.org:8080/#/c/10855/14/be/src/runtime/fragment-instance-state.cc@396 PS14, Line 396: DFAKE_SCOPED_LOCK(report_status_lock_); This is kind of cool. http://gerrit.cloudera.org:8080/#/c/10855/14/be/src/testutil/in-process-servers.cc File be/src/testutil/in-process-servers.cc: http://gerrit.cloudera.org:8080/#/c/10855/14/be/src/testutil/in-process-servers.cc@51 PS14, Line 51: ; Extra semicolon http://gerrit.cloudera.org:8080/#/c/10855/14/be/src/testutil/in-process-servers.cc@51 PS14, Line 51: FLAGS_krpc_port = I guess we can't set this to 0 to automatically choose an ephemeral port? We had some issues in the past with flaky tests because of port conflicts. -- To view, visit http://gerrit.cloudera.org:8080/10855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7638583b433dcac066b87198e448743d90415ebe Gerrit-Change-Number: 10855 Gerrit-PatchSet: 14 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Michal Ostrowski <mostr...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 08 Oct 2018 19:35:27 +0000 Gerrit-HasComments: Yes
