Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11623 )
Change subject: IMPALA-7673: Support values from other variables in Impala shell --var ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/11623/5/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/11623/5/shell/impala_shell.py@1507 PS5, Line 1507: def replace_variables(set_variables, query): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/11623/5/shell/impala_shell.py@1517 PS5, Line 1517: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/11623/5/shell/impala_shell.py@1534 PS5, Line 1534: def get_var_name(name): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/11623/5/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/11623/5/tests/shell/test_shell_commandline.py@736 PS5, Line 736: d flake8: F811 redefinition of unused 'test_var_substitution' from line 528 http://gerrit.cloudera.org:8080/#/c/11623/5/tests/shell/test_shell_commandline.py@750 PS5, Line 750: flake8: W292 no newline at end of file -- To view, visit http://gerrit.cloudera.org:8080/11623 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5b9fda329c45f2e5682f3cbc76d29ceca2e226a Gerrit-Change-Number: 11623 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Comment-Date: Tue, 09 Oct 2018 03:58:54 +0000 Gerrit-HasComments: Yes
