Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11626
Change subject: IMPALA-7677: Fix DCHECK failure in GroupingAggregator ...................................................................... IMPALA-7677: Fix DCHECK failure in GroupingAggregator After inserting all of its input into its Aggregators, StreamingAggregationNode performs some cleanup, such as calling InputDone() on each Aggregator. Previously, StreamingAggregationNode only checked that all of the child's batches had been fetched before doing this cleanup, which causes problems if the final child batch isn't processed fully in a single GetNext() call. In this case, multiple calls to InputDone() lead to a DCHECK failure. The solution is to only perform the cleanup once the final child batch has been fully processed. Testing: - Added an e2e test with a query that hits this condition. Change-Id: I851007a60472d0e53081c076c863c866c516677c --- M be/src/exec/streaming-aggregation-node.cc M testdata/workloads/functional-query/queries/QueryTest/multiple-distinct-aggs.test 2 files changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/11626/1 -- To view, visit http://gerrit.cloudera.org:8080/11626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I851007a60472d0e53081c076c863c866c516677c Gerrit-Change-Number: 11626 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall <thomasmarsh...@cmu.edu>
