Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11624 )
Change subject: IMPALA-7554: Update custom cluster tests to have new logs for sentry ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/11624/1/testdata/bin/run-sentry-service.sh File testdata/bin/run-sentry-service.sh: http://gerrit.cloudera.org:8080/#/c/11624/1/testdata/bin/run-sentry-service.sh@36 PS1, Line 36: LO > nit: 2 spaces Done http://gerrit.cloudera.org:8080/#/c/11624/1/testdata/bin/run-sentry-service.sh@38 PS1, Line 38: LO > nit: 2 spaces Done http://gerrit.cloudera.org:8080/#/c/11624/1/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/11624/1/tests/common/custom_cluster_test_suite.py@100 PS1, Line 100: > since we have 2 log dirs, it will be better to explain what this log_dir is Done http://gerrit.cloudera.org:8080/#/c/11624/1/tests/common/custom_cluster_test_suite.py@136 PS1, Line 136: self._start_sentry_service(method.func_dict[SENTRY_CONFIG], : method.func_dict.get(SENTRY_LOG_DIR)) : # Start a clean new cluster before each test : if IMPALA_LOG_DIR in method.func_dict: : self._start_impala_cluster(cluster_args, > Can be simplified to self._start_sentry_service(method.func_dir[SENTRY_CONF Done -- To view, visit http://gerrit.cloudera.org:8080/11624 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e538af7fd6e6ea21dc3f4442bdebf3b31558516 Gerrit-Change-Number: 11624 Gerrit-PatchSet: 2 Gerrit-Owner: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 10 Oct 2018 16:20:52 +0000 Gerrit-HasComments: Yes
