Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11410 )
Change subject: IMPALA-6249: Expose several build flags via web UI ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/11410/9/tests/run-tests.py File tests/run-tests.py: http://gerrit.cloudera.org:8080/#/c/11410/9/tests/run-tests.py@40 PS9, Line 40: 'webserver' > what do you think about doing something to prevent these sorts of errors in I think your approach makes a lot of sense. I'd also be comfortable with just having a blacklist. It looks like we already expected that adding a directory would include it in the execution, and if people get bitten by it, they can add it here. Alternatively we could add some magic DONT-TEST-THIS file in each folder that shouldn't get executed. I don't feel strongly and am good with either approach. -- To view, visit http://gerrit.cloudera.org:8080/11410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47e3ad4cbf844909bdaf22a6f9d7bd915dce3f19 Gerrit-Change-Number: 11410 Gerrit-PatchSet: 9 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Comment-Date: Wed, 10 Oct 2018 22:02:53 +0000 Gerrit-HasComments: Yes
