Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11650 )
Change subject: IMPALA-7272: Fix crash in StringMinMaxFilter ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11650/1/be/src/runtime/mem-pool.h File be/src/runtime/mem-pool.h: http://gerrit.cloudera.org:8080/#/c/11650/1/be/src/runtime/mem-pool.h@260 PS1, Line 260: uint8_t* ALWAYS_INLINE Allocate(int64_t size, int alignment) noexcept { > After a first pass, it looks like this isn't our only mis-use of MemPools ( Good to hear that DFAKE_SCOPED_LOCK() is catching the problem. How many other different instances are we talking about here ? My preference would be to fix all of them in this patch as there is a workaround for the bug in the min/max filter. Of course, if fixing some of those new cases requires a lot of refactoring or if there are too many places which suffer from this problem (which would be surprising), we can consider deferring the adding of DFAKE_SCOPED_LOCK() here. -- To view, visit http://gerrit.cloudera.org:8080/11650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I751cad7e6b75c9d95d7ad029bbd1e52fe09e8a29 Gerrit-Change-Number: 11650 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Comment-Date: Wed, 10 Oct 2018 23:12:04 +0000 Gerrit-HasComments: Yes