Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11649 )
Change subject: IMPALA-7688: Fix spurious error messages when updating owner privileges ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/11649/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/11649/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2892 PS6, Line 2892: whole method : // redundant. > didn't follow this part.. what do you mean by redundant? do you mean its "b The idea of this method is to basically do replicate what Sentry refresh does and yes, it's a best-effort so that users can start seeing the owner privileges without having to wait for a Sentry refresh. -- To view, visit http://gerrit.cloudera.org:8080/11649 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b46df01c5675ffed6528b7a73e68518664d8be0 Gerrit-Change-Number: 11649 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Thu, 11 Oct 2018 01:38:39 +0000 Gerrit-HasComments: Yes