Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11638 )
Change subject: IMPALA-7669: Gracefully handle concurrent invalidate/partial fetch RPCs ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11638/1/fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java File fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java: http://gerrit.cloudera.org:8080/#/c/11638/1/fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java@144 PS1, Line 144: if (cause_ == null) { : throw new TableLoadingException("Table state on the Catalog server has been " + : "invalidated by another concurrent request. Please retry the query."); > ah, I see. I think in other places we also make an assumption that getOrLoa I was looking at the callers of this. I see a few of them actually expect that the table could still be in an invalidated by the time this returns [1,2] (multiple DDLs actually call the wrapper [2]) One interesting caller here is [3,4] (that you modified :)) is probably affected. [1] https://github.com/apache/impala/blob/0047191262d6a90eb704dff880efe6e625b805bc/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java#L452 [2] https://github.com/apache/impala/blob/0047191262d6a90eb704dff880efe6e625b805bc/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java#L3672 [3] https://github.com/apache/impala/blob/0047191262d6a90eb704dff880efe6e625b805bc/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java#L1412 [4] https://github.com/apache/impala/commit/fa6db57769ddef60f6d4f8aa342fb1b0a4d4eb8b#diff-b0fabd1ea9efd6f9e7fdd6f01ecedfbd -- To view, visit http://gerrit.cloudera.org:8080/11638 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8533f73f25ca42a20f146ddfd95d4213add9b705 Gerrit-Change-Number: 11638 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 12 Oct 2018 01:17:03 +0000 Gerrit-HasComments: Yes
