Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 )
Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11663/1/tests/authorization/test_show_grant.py File tests/authorization/test_show_grant.py: http://gerrit.cloudera.org:8080/#/c/11663/1/tests/authorization/test_show_grant.py@35 PS1, Line 35: class TestShowGrant(CustomClusterTestSuite): > A file name change from TestShowGrantUser to TestShowGrant since I think it that's fine, but since its mostly a file rename fwict, with a test added, it would be useful to hint to git that its a rename (not sure when this happens on its own vs. when it needs to be explicitly hinted) -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 12 Oct 2018 15:51:16 +0000 Gerrit-HasComments: Yes
