Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11520 )
Change subject: IMPALA-7543: Enhance scan ranges to support sub-ranges ...................................................................... Patch Set 6: Code-Review+2 (1 comment) One small comment. Otherwise, looks good! http://gerrit.cloudera.org:8080/#/c/11520/6/be/src/runtime/io/scan-range.cc File be/src/runtime/io/scan-range.cc: http://gerrit.cloudera.org:8080/#/c/11520/6/be/src/runtime/io/scan-range.cc@466 PS6, Line 466: void ScanRange::Reset(hdfsFS fs, const char* file, int64_t len, int64_t offset, : int disk_id, bool expected_local, const BufferOpts& buffer_opts, : vector<SubRange>&& sub_ranges, void* meta_data) { : Reset(fs, file, len, offset, disk_id, expected_local, buffer_opts, meta_data); : AddSubRanges(move(sub_ranges)); : } Nit: Just as a style thing, my preference would be to have the base Reset() take sub_ranges as an argument and initialize sub_ranges_. The other Reset() would call in with an empty list. i.e. Reset(args) -> Reset(args, sub_ranges) rather than Reset(args, sub_ranges) -> Reset(args) then init sub_ranges In this case, it might make sense for AddSubRanges() to be renamed to InitSubRanges(). -- To view, visit http://gerrit.cloudera.org:8080/11520 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea26ba386713990f7671aab5a372cf449b8d51e4 Gerrit-Change-Number: 11520 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 12 Oct 2018 23:34:07 +0000 Gerrit-HasComments: Yes
