Pooja Nilangekar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11669 )

Change subject: IMPALA-7545: Add queuing reason to query log
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11669/4/tests/custom_cluster/test_admission_controller.py
File tests/custom_cluster/test_admission_controller.py:

http://gerrit.cloudera.org:8080/#/c/11669/4/tests/custom_cluster/test_admission_controller.py@845
PS4, Line 845: queuing
> nit: queuing
Done


http://gerrit.cloudera.org:8080/#/c/11669/4/tests/custom_cluster/test_admission_controller.py@849
PS4, Line 849:     assert "Admission result : Queued" in log, log
> also add assert for "Admission result: Queued"
Done


http://gerrit.cloudera.org:8080/#/c/11669/4/tests/custom_cluster/test_admission_controller.py@849
PS4, Line 849: "Admission result : Queued" in log, log
             :     assert "Latest admission queue reason : number of running 
queries 1 i
> just use "string_to_search" in str instead of a regex search. no need for e
Done



--
To view, visit http://gerrit.cloudera.org:8080/11669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e5d8de4f6691a9ba2594ca68c54ea4dca760545
Gerrit-Change-Number: 11669
Gerrit-PatchSet: 5
Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Oct 2018 16:57:46 +0000
Gerrit-HasComments: Yes

Reply via email to