Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11677 )
Change subject: IMPALA-7702: enable fetch incremental stats by default ...................................................................... Patch Set 2: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/11677/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11677/2//COMMIT_MSG@18 PS2, Line 18: This patch makes this : easier by not requiring this rephrase? http://gerrit.cloudera.org:8080/#/c/11677/2/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/11677/2/be/src/common/global-flags.cc@217 PS2, Line 217: "coordinators."); Mention that this is not used in local catalog mode? http://gerrit.cloudera.org:8080/#/c/11677/2/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/11677/2/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@617 PS2, Line 617: Add a comment that the pull flag doesn't make much sense in local catalog mode and hence is overridden? -- To view, visit http://gerrit.cloudera.org:8080/11677 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5601a24f81bb3466cff5308c7093d2765bb1c481 Gerrit-Change-Number: 11677 Gerrit-PatchSet: 2 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Comment-Date: Mon, 15 Oct 2018 22:08:31 +0000 Gerrit-HasComments: Yes
