Vuk Ercegovac has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11706 )

Change subject: IMPALA-7689: Reduce per column per partition stats estimate size
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

looks good. main thing for this one that would be helpful is to explain where 
the 400 came from (and from there, the 200).

http://gerrit.cloudera.org:8080/#/c/11706/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java:

http://gerrit.cloudera.org:8080/#/c/11706/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@199
PS1, Line 199: 200
the 400 byte estimate was pretty accurate from the examples I saw. is there a 
pointer you can put here to explain how that was derived, then explain the 50% 
of that from compression?



--
To view, visit http://gerrit.cloudera.org:8080/11706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I347b41d9b298d7cd73ec812692172e0511415eee
Gerrit-Change-Number: 11706
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Oct 2018 03:42:53 +0000
Gerrit-HasComments: Yes

Reply via email to