Anuj Phadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11540 )
Change subject: IMPALA-7555: Set socket timeout in impala-shell ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/11540/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11540/9//COMMIT_MSG@16 PS9, Line 16: 1. Added a test where I create a random listening socket. > This list should also mention the automatic test added in this change. Done http://gerrit.cloudera.org:8080/#/c/11540/9/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/11540/9/tests/shell/test_shell_commandline.py@770 PS9, Line 770: # maximum number of queued connections on this socket is 1. : s.listen(1) > Is this needed? listen takes 1 value by default E TypeError: listen() takes exactly one argument Do you want me to choose some other value? -- To view, visit http://gerrit.cloudera.org:8080/11540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I130fc47f7a83f591918d6842634b4e5787d00813 Gerrit-Change-Number: 11540 Gerrit-PatchSet: 10 Gerrit-Owner: Anuj Phadke <apha...@cloudera.com> Gerrit-Reviewer: Anuj Phadke <apha...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Comment-Date: Wed, 17 Oct 2018 20:42:47 +0000 Gerrit-HasComments: Yes
