Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 )
Change subject: IMPALA-5004: Switch to sorting node for large TopN queries ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11698/1/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/11698/1/be/src/service/query-options.cc@720 PS1, Line 720: StringParser::StringToInt<int64_t>(value.c_str(), value.length(), &result); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/11698/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/11698/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@313 PS1, Line 313: if (useTopN && estimatedTopNMaterializedSize < ctx_.getQueryOptions().topn_bytes_limit) { line too long (95 > 90) -- To view, visit http://gerrit.cloudera.org:8080/11698 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34c9db33c9302b55e9978f53f9c7061f2806c8a9 Gerrit-Change-Number: 11698 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Wed, 17 Oct 2018 22:35:05 +0000 Gerrit-HasComments: Yes
