Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11721 )

Change subject: IMPALA-7721: Fix broken /catalog_object web API when getting a 
privilege
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11721/4/be/src/catalog/catalog-util.cc
File be/src/catalog/catalog-util.cc:

http://gerrit.cloudera.org:8080/#/c/11721/4/be/src/catalog/catalog-util.cc@a214
PS4, Line 214:
> what is the severity of the issue? ... priv doesn't get shown, crash, somet
privilege doesn't get shown.


http://gerrit.cloudera.org:8080/#/c/11721/4/be/src/catalog/catalog-util.cc@271
PS4, Line 271:       Status status = 
TPrivilegeLevelFromObjectName(key_value[1], &privilege_level);
> is there a comparable parsing method on the java side (frontend)? if so, wo
There is for building the privilege name and not parsing it.


http://gerrit.cloudera.org:8080/#/c/11721/4/be/src/catalog/catalog-util.cc@274
PS4, Line 274:     } else if (key_value[0] == "grantoption") {
> const
Done



--
To view, visit http://gerrit.cloudera.org:8080/11721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I525149d113a1437c1e1493ad3c25a755e370b0c7
Gerrit-Change-Number: 11721
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Oct 2018 23:22:17 +0000
Gerrit-HasComments: Yes

Reply via email to