Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11734 )
Change subject: IMPALA-7729: Fix invalidate metadata hang when there is an upper case role name ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/11734/4/fe/src/main/java/org/apache/impala/util/SentryProxy.java File fe/src/main/java/org/apache/impala/util/SentryProxy.java: http://gerrit.cloudera.org:8080/#/c/11734/4/fe/src/main/java/org/apache/impala/util/SentryProxy.java@172 PS4, Line 172: he key > got it. keeping track of what's from sentry and what isn't and how that may If for some reason, Sentry decides to make principal names to be case sensitive, I don't think we want to lower case the strings. Obviously when they do that, we also need to CatalogObjectCache to be case sensitive. Transforming the Sentry data structures into Impala data structures can be an expensive operations since we have to go through N privileges. I'll add more comments. http://gerrit.cloudera.org:8080/#/c/11734/4/tests/authorization/test_grant_revoke.py File tests/authorization/test_grant_revoke.py: http://gerrit.cloudera.org:8080/#/c/11734/4/tests/authorization/test_grant_revoke.py@388 PS4, Line 388: tadata won't hang due > sorry, meant role. this is an e2e test so if could be done here? anyways, i Done -- To view, visit http://gerrit.cloudera.org:8080/11734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5aa6f626ad3df4e9321ed18273d045517bc099c2 Gerrit-Change-Number: 11734 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 19 Oct 2018 17:14:22 +0000 Gerrit-HasComments: Yes
