Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11582 )
Change subject: IMPALA-6658: improve Parquet RLE for low bit widths ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/11582/2/be/src/util/rle-encoding.h File be/src/util/rle-encoding.h: http://gerrit.cloudera.org:8080/#/c/11582/2/be/src/util/rle-encoding.h@203 PS2, Line 203: the previous run is flushed out I think that it would be helpful to update this comment with a brief discussion of the use of the circular buffer and the way that you flush 8 values at a time when you have a not long enough repeated run. http://gerrit.cloudera.org:8080/#/c/11582/2/be/src/util/rle-encoding.h@348 PS2, Line 348: most values most MAX_RUN_LENGTH_BUFFER values http://gerrit.cloudera.org:8080/#/c/11582/2/be/src/util/rle-encoding.h@350 PS2, Line 350: _ nit: period, here and elsewhere http://gerrit.cloudera.org:8080/#/c/11582/2/be/src/util/rle-test.cc File be/src/util/rle-test.cc: http://gerrit.cloudera.org:8080/#/c/11582/2/be/src/util/rle-test.cc@148 PS2, Line 148: Rle nit: RleTest -- To view, visit http://gerrit.cloudera.org:8080/11582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I191a581d3f699b6669e48ac9dc39c76ed77c4a76 Gerrit-Change-Number: 11582 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Comment-Date: Fri, 19 Oct 2018 21:45:33 +0000 Gerrit-HasComments: Yes
