Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11794 )
Change subject: IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata ...................................................................... IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata Before this patch, a bug in SentryProxy caused a hang when running invalidate metadata due to privilege version inconsistency. I was able to manually reproduce the issue by doing the following steps: 1. Get all Sentry role privileges for role a: [x, y] --> in SentryProxy 2. Add a sleep statement before getting all Sentry roles to simulate the timing issue--> in SentryProxy 3. Remove role a --> Externally via Sentry CLI 4. Privileges x and y in step 1 do not get removed in the catalog even those they were removed in step 3, which causes the catalog version inconsistency 5. Run invalidate metadata, this will cause it to hang due to catalog version inconsistency The fix is to remove all privileges in the catalog if there are no privileges (null or empty) returned by Sentry. Testing: - Manually tested the patch with by the above steps and did not encounter the hang when issuing invalidate metadata. Change-Id: Ib1e0db2b1f727476f489c732c4f4e5bc1582429f Reviewed-on: http://gerrit.cloudera.org:8080/11794 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M fe/src/main/java/org/apache/impala/util/SentryProxy.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/11794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib1e0db2b1f727476f489c732c4f4e5bc1582429f Gerrit-Change-Number: 11794 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>