Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11828 )
Change subject: IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong() ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11828/1/be/src/exec/scanner-context.inline.h File be/src/exec/scanner-context.inline.h: http://gerrit.cloudera.org:8080/#/c/11828/1/be/src/exec/scanner-context.inline.h@169 PS1, Line 169: if (is_negative) *value = *value ^ (static_cast<int64_t>(-1)); > nit: could put conditional on one line. Done -- To view, visit http://gerrit.cloudera.org:8080/11828 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417 Gerrit-Change-Number: 11828 Gerrit-PatchSet: 2 Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 30 Oct 2018 23:54:20 +0000 Gerrit-HasComments: Yes
