Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11830 )
Change subject: IMPALA-2566: Remove ability to access impala builtin cast functions directly ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11830/2/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java File fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java: http://gerrit.cloudera.org:8080/#/c/11830/2/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java@184 PS2, Line 184: private boolean isBuiltinCastFunction(){ space before { -- To view, visit http://gerrit.cloudera.org:8080/11830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f562607aaaf728fc417066565811bbd269baaa8 Gerrit-Change-Number: 11830 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 31 Oct 2018 22:43:33 +0000 Gerrit-HasComments: Yes
