David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11410 )
Change subject: IMPALA-6249: Expose several build flags via web UI ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/11410/12/tests/run-tests.py File tests/run-tests.py: http://gerrit.cloudera.org:8080/#/c/11410/12/tests/run-tests.py@42 PS12, Line 42: INVALID_TEST_DIRS = ['aux_parquet_data_load', 'test-hive-udfs', 'comparison', 'benchmark', > Yes, that correct. It prevents devs from adding a new folder under tests/ a Ah yeah, I just saw the comment in JIRA after I made this comment. I understand the necessity of doing something like this, but -- ugh, it's a little depressing. We really backed ourselves into a corner with this approach. Can you add a comment here that explains the need for this list, such that someone looking at this file later can more easily understand the rationale at a glance, outside of the context of this code review and the related JIRA? Also, perhaps a better name would be something like TEST_UTILITY_DIRS or TEST_HELPER_DIRS? Thanks! -- To view, visit http://gerrit.cloudera.org:8080/11410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47e3ad4cbf844909bdaf22a6f9d7bd915dce3f19 Gerrit-Change-Number: 11410 Gerrit-PatchSet: 12 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 01 Nov 2018 17:54:07 +0000 Gerrit-HasComments: Yes
