Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11873 )
Change subject: IMPALA-7565: Add startup flag to set thrift connection setup thread pool size ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11873/1/be/src/rpc/TAcceptQueueServer.cpp File be/src/rpc/TAcceptQueueServer.cpp: http://gerrit.cloudera.org:8080/#/c/11873/1/be/src/rpc/TAcceptQueueServer.cpp@30 PS1, Line 30: internal connections nit: not necessarily Impala internal connections. This class is used for Beeswax and HS2 servers too. http://gerrit.cloudera.org:8080/#/c/11873/1/be/src/rpc/TAcceptQueueServer.cpp@32 PS1, Line 32: connection May be "accepted_cnxn_setup_thread_pool_size" so it's consistent with the other knob. http://gerrit.cloudera.org:8080/#/c/11873/1/be/src/rpc/TAcceptQueueServer.cpp@34 PS1, Line 34: internal connections nit: not necessarily Impala internal connections. This class is used for Beeswax and HS2 servers too. -- To view, visit http://gerrit.cloudera.org:8080/11873 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31344321a5f9e840a399ccb0f963c0759e2ab234 Gerrit-Change-Number: 11873 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Sat, 03 Nov 2018 00:54:58 +0000 Gerrit-HasComments: Yes
