Hello Csaba Ringhofer, Impala Public Jenkins, Vuk Ercegovac,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11883
to look at the new patch set (#2).
Change subject: IMPALA-7808: Refactor Analyzer for easier debugging
......................................................................
IMPALA-7808: Refactor Analyzer for easier debugging
Changes two blocks of code to make debugging easier. No functional
changes occur; changes are pure refactoring. A trivial change in
AnalyzerContext removes a nested conditional clause.
A larger change in SelectStmt takes the large analysis function and
breaks it into a series of smaller functions. The functions were large
because they shared state: variables created near the top are used much
later near the bottom.
To solve this, moved the code into an "algorithm" class whose only job
is to hold onto the temporary state so that the big function can be
broken into smaller pieces, with the temporary class fields used in
place of the former local variables.
This CR introduces the inner algorithm class, but leaves the original
code at the original indent level to make reviews easier. You should see
the same code, now broken into smaller functions, with a new "driver"
section that calls these new functions from where the code itself
previously resided.
Once a review is done of the code in this form, I can revise this CR
with the only change being to indent the methods one level, which can be
reviewed as a second step.
One block of code had to be moved below the inner class since it is not
part of the analysis process.
Testing: No functional change, changes are purely structure.
Reran all tests, which passed.
Change-Id: I576c80c4c7a974df226fc91d8903db275069ed52
---
M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
2 files changed, 625 insertions(+), 558 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/11883/2
--
To view, visit http://gerrit.cloudera.org:8080/11883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I576c80c4c7a974df226fc91d8903db275069ed52
Gerrit-Change-Number: 11883
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Rogers <par0...@yahoo.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
