Hello Bharath Vissapragada, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11890
to look at the new patch set (#2).
Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging
......................................................................
IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging
Impala provides a single test class ExprRewriteRulesTest for all rewrite
rules. Each rule class has an associated test function. The
SimplifyConditionalRule class is complex, and the result test function
is quite large.
When doing work to modify a particular conditional rewrite, it became
clear that debugging would be much easier if each detailed rewrite had
its own test rather than using one huge test function. This ticket asks
to break up the big function. (JUnit does not care about small vs. large
functions.)
This patch splits the function separate from later work that will modify
the tests themselves.
Also unified test function naming, using the standard "javaStyle" rather
than the unusual "CppStyle" that was used.
Testing: this is a test, ran the test to ensure it still passes.
Change-Id: I99a28b170bc0132424041e51f61ebe5c848c4083
---
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
1 file changed, 76 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/11890/2
--
To view, visit http://gerrit.cloudera.org:8080/11890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99a28b170bc0132424041e51f61ebe5c848c4083
Gerrit-Change-Number: 11890
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Rogers <par0...@yahoo.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
