Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11947 )
Change subject: IMPALA-6656: BufferAllocator observability ...................................................................... IMPALA-6656: BufferAllocator observability Adds a set of metrics per allocator arena in the buffer pool that help understand how buffers are being allocated and how much time is spent in the system allocator (i.e. TCMalloc). These are low level metrics that require some interpretation but provide visibility into behaviour that was previously totally opaque. Also tracks the total time spent in the system allocator in the query profile, to provide clues if time spent in TCMalloc is a perf issue for a particular query (e.g. if it's hitting a lot of lock contention). Backend tests required tweaks to avoid double-registration of the new metrics. Also switch default sort in /metrics to be by name, so that it's easier to locate metrics. Change-Id: I12b740b8ea7773b3215681531dfa62db55cfdf18 --- M be/src/runtime/bufferpool/buffer-allocator-test.cc M be/src/runtime/bufferpool/buffer-allocator.cc M be/src/runtime/bufferpool/buffer-allocator.h M be/src/runtime/bufferpool/buffer-pool-counters.h M be/src/runtime/bufferpool/buffer-pool-test.cc M be/src/runtime/bufferpool/buffer-pool.cc M be/src/runtime/bufferpool/buffer-pool.h M be/src/runtime/bufferpool/suballocator-test.cc M be/src/runtime/exec-env.cc M be/src/runtime/test-env.cc M be/src/runtime/test-env.h M be/src/util/metrics.h M common/thrift/metrics.json M www/metric_group.tmpl 14 files changed, 272 insertions(+), 72 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/11947/2 -- To view, visit http://gerrit.cloudera.org:8080/11947 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I12b740b8ea7773b3215681531dfa62db55cfdf18 Gerrit-Change-Number: 11947 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>