Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11964 )
Change subject: IMPALA-7852: Fix some flakiness in test_hash_join_timer.py ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11964/1/tests/beeswax/impala_beeswax.py File tests/beeswax/impala_beeswax.py: http://gerrit.cloudera.org:8080/#/c/11964/1/tests/beeswax/impala_beeswax.py@206 PS1, Line 206: # Get the profile after unregistering the query so ExecSummary is included in it. > I think this is introducing a new race between the query being evicted from Good point although in practice, given the default size of query log and the size of the race window, it's unlikely to occur. Let me add a check in the test_hash_join_timer.py to make sure we check if the profile is not None. -- To view, visit http://gerrit.cloudera.org:8080/11964 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I851824dffb78c7731e60793d90f1e57050c54955 Gerrit-Change-Number: 11964 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 20 Nov 2018 19:24:43 +0000 Gerrit-HasComments: Yes
