Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11954 )
Change subject: IMPALA-7867 (Part 1): Expose List in TreeNode, parser ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11954/2/fe/src/main/java/org/apache/impala/common/TreeNode.java File fe/src/main/java/org/apache/impala/common/TreeNode.java: http://gerrit.cloudera.org:8080/#/c/11954/2/fe/src/main/java/org/apache/impala/common/TreeNode.java@62 PS2, Line 62: ult = new A > Reverted this for now. The problem is that this method appears to be type-s You still can replace ArrayList with List instead of reverting everything. Yes, this is an issue with type erasure in Java and I'm afraid there's no way around it. Despite being "unsafe", from the API standpoint TreeNode<NodeType> is far more readable than TreeNode<?> since TreeNode<?> means TreeNode can hold anything when the fact that it's always going to be NodeType for this particular class. -- To view, visit http://gerrit.cloudera.org:8080/11954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebab7dccdb4b2fa0b5ca812beab0e8bdba39f539 Gerrit-Change-Number: 11954 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <par0...@yahoo.com> Gerrit-Comment-Date: Wed, 21 Nov 2018 02:39:03 +0000 Gerrit-HasComments: Yes
